[Synce-devel] [PATCH] synce-gnome: extra diagnostics for user

[petr bug]

1) Make sure odccm is NOT running
2) Start synce-gnome/src/test.py

What happens: Python spits some unreadable dump. (It is a stack trace,
since odccm is not connected to d-bus, so binding to d-bus name
org.synce.odccm fails.)
Traceback (most recent call last):
File "synce/synce-gnome.cleaned/src/test.py", line 130, in <module>
TestApp()
File "synce/synce-gnome.cleaned/src/test.py", line 14, in __init__
proxy_obj = bus.get_object("org.synce.odccm",
"/org/synce/odccm/DeviceManager")
File "/var/lib/python-support/python2.5/dbus/_dbus.py", line 410, in
get_object
follow_name_owner_changes=follow_name_owner_changes)
File "/var/lib/python-support/python2.5/dbus/proxies.py", line 230,
in __init__
_dbus_bindings.UInt32(0))
File "/var/lib/python-support/python2.5/dbus/proxies.py", line 169,
in __call__
reply_message =
self._connection.send_message_with_reply_and_block(message, timeout)
dbus.DBusException: org.freedesktop.DBus.Error.ServiceUnknown: The
name org.synce.odccm was not provided by any .service files

This is unreadable to user. Some people say user should not be to
crash program, be it wrong access to memory, assertion or exception.
If it makes no sense to continue it is OK to exit, but some user
readable explanation is a must, additional debugging info is then
aceptable.

This patch says that odccm must be running.

If user does not know what synce-gnome does and device is not
connected, he/she may be surprised it does nothing (in user
interaction sense). Therefore this patch displays "Plug your device
in" or something.

[Jonny Lamb]

Post by petr bug
This patch says that odccm must be running.

Great! This looks fine for me. I shall commit this as soon as I can. It
also reminds me to put in a try except case for when notification-daemon
isn't available -- there are lots of support requests for synce-gnome
about that too.

Thanks again!

[Jonny Lamb]

Post by petr bug
This patch says that odccm must be running.

Again, sorry for the delay -- committed in r3043.

Many thanks.