XSL refactoring

[Aurelien Bompard]

Dr John Gow,

Following patch 2827143 [1], I've fixed a "spec conformance bug" in the *-
to-airsync.xsl files, and thought the XSL files are becoming a little
"hairy".

Mark told me you're in charge of sync-engine, so I'm asking you directly :
if you like, I can refactor the stylesheets with templates and variables. I
think that would make sense since many tags are near-identical.

We could avoid regression bugs with the unit tests, although they don't
cover every possible transformation at the moment.

Do you have something planned in this general direction ? Are you interested
in the refactoring ?

Thanks

Aurélien

[1]
https://sourceforge.net/tracker/?func=detail&atid=399603&aid=2827143&group_id=30550

[Mark Ellis]

Post by Aurelien Bompard
Dr John Gow,
Following patch 2827143 [1], I've fixed a "spec conformance bug" in the *-
to-airsync.xsl files, and thought the XSL files are becoming a little
"hairy".
if you like, I can refactor the stylesheets with templates and variables. I
think that would make sense since many tags are near-identical.
We could avoid regression bugs with the unit tests, although they don't
cover every possible transformation at the moment.
Do you have something planned in this general direction ? Are you interested
in the refactoring ?
Thanks
Aurélien
[1]
https://sourceforge.net/tracker/?func=detail&atid=399603&aid=2827143&group_id=30550

Aurelien, in the absence of any objections, I would say please go ahead,
your help will be most welcome :)

Mark

[David Eriksson]

Post by Mark Ellis

Post by Aurelien Bompard
Dr John Gow,
Following patch 2827143 [1], I've fixed a "spec conformance bug" in the *-
to-airsync.xsl files, and thought the XSL files are becoming a little
"hairy".
if you like, I can refactor the stylesheets with templates and variables. I
think that would make sense since many tags are near-identical.
We could avoid regression bugs with the unit tests, although they don't
cover every possible transformation at the moment.
Do you have something planned in this general direction ? Are you interested
in the refactoring ?
Thanks
Aurélien
[1]
https://sourceforge.net/tracker/?func=detail&atid=399603&aid=2827143&group_id=30550

Aurelien, in the absence of any objections, I would say please go ahead,
your help will be most welcome :)

+1


Cheers,

David Eriksson, http://www.divideandconquer.se/

[Aurelien Bompard]

Post by Mark Ellis
Aurelien, in the absence of any objections, I would say please go
ahead, your help will be most welcome :)

+1

Actually, John replied to me privately, he's fine with the idea. I've sent
him the first part of my work, which apparently seem to look good :)

I'll remember to keep the mailing-list in CC now.

Thanks

Aurélien

[Aurelien Bompard]

I like!

Great !

Do you have commit rights on SVN or do you want me to commit it?

No, I don't have the commit rights. Until now I've sent 4 patches to
SynCE[1] and Mark committed them himself. If you could commit this one
that'd be great.
[1]
http://sourceforge.net/tracker/?limit=10&func=&group_id=30550&atid=399603&assignee=&status=&category=&artgroup=&keyword=&submitter=&artifact_id=&assignee=&status=&category=&artgroup=&submitter=abompard&keyword=&artifact_id=&submit=Filter

Don't forget to update the changelog :)

Oh, that's right. Last times Mark updated it himself, but that's not a
reason to keep being lazy :)

If you are happy to extend this to the event and tasks, that would be
great.

OK, I'll do it. Thanks for your support.
I'm adding the list as CC, if you don't mind, to keep the rest of the team
posted.


Aurélien

[Mark Ellis]

Post by Aurelien Bompard

I like!

Great !

Do you have commit rights on SVN or do you want me to commit it?

I've just given you commit access, have fun ...

Post by Aurelien Bompard
No, I don't have the commit rights. Until now I've sent 4 patches to
SynCE[1] and Mark committed them himself. If you could commit this one
that'd be great.
[1]
http://sourceforge.net/tracker/?limit=10&func=&group_id=30550&atid=399603&assignee=&status=&category=&artgroup=&keyword=&submitter=&artifact_id=&assignee=&status=&category=&artgroup=&submitter=abompard&keyword=&artifact_id=&submit=Filter

Don't forget to update the changelog :)

Oh, that's right. Last times Mark updated it himself, but that's not a
reason to keep being lazy :)

If you are happy to extend this to the event and tasks, that would be
great.

OK, I'll do it. Thanks for your support.
I'm adding the list as CC, if you don't mind, to keep the rest of the team
posted.
Aurélien

[Aurelien Bompard]

Post by Mark Ellis
I've just given you commit access, have fun ...

Wow, thank you Mark !
Any instructions available to keep me from making beginner's mistakes ? I
know SVN, it's just if you have SynCE-specific policies, things like that.

Aurélien

[Mark Ellis]

Post by Aurelien Bompard

Post by Mark Ellis
I've just given you commit access, have fun ...

Wow, thank you Mark !
Any instructions available to keep me from making beginner's mistakes ? I
know SVN, it's just if you have SynCE-specific policies, things like that.
Aurélien

Nothing specific, just the normal kind of thing.